perf(campaigns): standardize queries for listed statuses - #197
Open
ajohn25 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes a few changes to boost performance for loading campaign statuses:
campaign_contact.archivedto only filter when partial index usage is likelycampaign_contact.archived, to improve chance of index usagecampaign_contact.archivedat all. The partial index is unlikely to be used in this case, and the trigger on campaign archiving already guarantees thatcampaign_contact.archived = campaign.is_archivedgetHasUnassignedContactsused assignable,getHasUnhandledMessagesused escalated)Motivation and Context
Performance + readability
While this is rebased off dialer so that related queries are also refactored, no need to review till after dialer sprint.
How Has This Been Tested?
This has been tested locally
Claude generated SQL output can be found here
Screenshots (if appropriate):
Documentation Changes
Checklist: