fix(graphql): use date scalar type for timestamps - #225
Open
ajohn25 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This converts a few
Stringtimestamps scattered in the codebase to the customDateGraphQL scalar typeMotivation and Context
Noticed bug with displaying template campaign creation date as shown in the screenshot here #224 The other timestamps affected by this PR aren't displayed to users
The
Datescalar ensures the timestamps are returned as ISO strings, which is how they're generally worked with throughout the codebase. The serialization code for the type (fromnode_modules) :How Has This Been Tested?
This has been tested locally
Screenshots (if appropriate):
Documentation Changes
Checklist: