perf: prefer campaign contact archived checks over campaign - #244
Open
ajohn25 wants to merge 1 commit into
Open
Conversation
campaign_contact.archived is kept in sync with campaign.is_archived, so filtering on both (or joining to campaign solely to read is_archived) is dead weight. Removes an unused select in sendMessage, an unnecessary leftJoin in removeOptOut, and an unnecessary join in the releaseMessages raw update.
ajohn25
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
campaign_contact.archivedis kept in sync withcampaign.is_archived, so several queries were doing redundant work by also joining to / filtering oncampaign.is_archived.sendMessage: removed the redundantcampaign.is_archivedwhere-clause (already covered bycampaign_contact.archived = false) and the unusedis_archivedselect alias.removeOptOut: dropped theleftJointocampaign— it existed solely to filteris_archived, whichcampaign_contact.archivedalready gives us directly.releaseMessages: dropped the unnecessarycampaignjoin in the rawUPDATE ... FROMclause — theis_archivedvalue is already substituted as a literal from a separate lookup, and no othercampaigncolumn was used.Test plan
yarn test(send-message / root-mutations specs)removeOptOutpath)releaseMessagespath)sendMessagepath)🤖 Generated with Claude Code