chore(campaign): clean up non null types - #251
Open
ajohn25 wants to merge 3 commits into
Open
Conversation
boba1007
force-pushed
the
chore-tidy-campaign
branch
from
August 20, 2026 15:26
a63ba40 to
651bdbb
Compare
boba1007
force-pushed
the
chore-tidy-campaign
branch
from
August 20, 2026 15:33
651bdbb to
a3648e0
Compare
ajohn25
force-pushed
the
chore-tidy-campaign
branch
from
August 29, 2026 20:35
a3648e0 to
edd9a4d
Compare
ajohn25
force-pushed
the
chore-tidy-campaign
branch
from
August 29, 2026 20:40
edd9a4d to
428cd01
Compare
boba1007
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This marks as non nullable a few database and GraphQL types for
campaignthat are always given a non null value in code, but previously not marked as such in the schemacustomFieldAverageLengthsis also updated inschema.graphl(just missed ayarn codegenrun in #238Motivation and Context
Enforcing types more strictly + cleaning up extra verbose code for clarity
Direct changes are in the migration and
gql-schema/campaign.ts. Other changes to the codebase and tests are derived from the cleaned up types.How Has This Been Tested?
This has been tested locally
Also confirmed in prod that no campaigns exist with null values for any of these fields
Screenshots (if appropriate):
Documentation Changes
Checklist: