Skip to content

build!: upgrade to v24 LTS #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ajohn25 wants to merge 7 commits into
base: chore-crypto-prep-24
Choose a base branch
from
Draft

build!: upgrade to v24 LTS #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d3ce30
build!: upgrade to v24 LTS
ajohn25 Nov 10, 2025
b47adcb
fix: use ivs with encryption functions
ajohn25 Nov 10, 2025
46e265f
fix: remove merge artifacts
ajohn25 Mar 24, 2026
92ec5b3
chore(node): update types
ajohn25 Apr 11, 2026
ae18641
chore: update tool-versions
ajohn25 Apr 14, 2026
778630d
chore: update to 24.14
ajohn25 Apr 14, 2026
725f7a6
ci: use bookworm instead of bullseye
ajohn25 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
matrix:
node-version:
- 20.16.0-bullseye
- 24.14.0-bookworm
container:
image: node:${{ matrix.node-version }}

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.16
24.14
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
nodejs 16.14.0
nodejs 24.14.1
yarn 1.22.19
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### Dependency Cacher
### -------------------------
FROM endeveit/docker-jq:latest as deps

Check warning on line 3 in Dockerfile

View workflow job for this annotation

GitHub Actions / Hadolint 

Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag

# To prevent cache invalidation from changes in fields other than dependencies
# https://stackoverflow.com/a/59606373
Expand All @@ -10,7 +10,7 @@

### Fat Build
### -------------------------
FROM node:20.16.0 AS builder
FROM node:24.14.0 AS builder

WORKDIR /usr/Spoke

Expand All @@ -36,14 +36,14 @@

### Slim Deploy
### -------------------------
FROM node:20.16.0
FROM node:24.14.0

WORKDIR /usr/Spoke

# Install and cache production dependencies
COPY --from=deps /tmp/deps.json ./package.json
COPY yarn.lock ./
RUN yarn install --production

Check notice on line 46 in Dockerfile

View workflow job for this annotation

GitHub Actions / Hadolint 

`yarn cache clean` missing after `yarn install` was run.

# Copy only the built source
COPY --from=builder /usr/Spoke/build ./build
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ that goal. See [`HOWTO_migrate-from-moveon-main.md`](./docs/HOWTO_migrate-from-m

Runtimes and package managers:

- Node (^20.16)
- Node (^24.14)
- Yarn (>= 1.19.1)

External services:
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"engines": {
"npm": "please-use-yarn",
"yarn": ">= 1.19.1",
"node": "^20.16.0"
"node": "^24.14.0"
},
"scripts": {
"preinstall": "node -e \"if(process.env.npm_execpath.indexOf('yarn') === -1) throw new Error('spoke must be installed with Yarn: https://yarnpkg.com/')\"",
Expand Down Expand Up @@ -234,7 +234,7 @@
"@types/lodash": "^4.14.168",
"@types/luxon": "^1.25.2",
"@types/material-ui": "^0.21.7",
"@types/node": "^16.11.26",
"@types/node": "^24.12.2",
"@types/node-cron": "^2.0.3",
"@types/nodemailer": "^6.4.0",
"@types/papaparse": "^5.3.5",
Expand Down
15 changes: 11 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6430,10 +6430,12 @@
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.0.13.tgz#ee1128e881b874c371374c1f72201893616417c9"
integrity sha512-rouEWBImiRaSJsVA+ITTFM6ZxibuAlTuNOCyxVbwreu6k6+ujs7DfnU9o+PShFhET78pMBl3eH+AGSI5eOTkPA==

"@types/node@^16.11.26":
version "16.11.26"
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.26.tgz#63d204d136c9916fb4dcd1b50f9740fe86884e47"
integrity sha512-GZ7bu5A6+4DtG7q9GsoHXy3ALcgeIHP4NnL0Vv2wu0uUB/yQex26v0tf6/na1mm0+bS9Uw+0DFex7aaKr2qawQ==
"@types/node@^24.12.2":
version "24.12.2"
resolved "https://registry.yarnpkg.com/@types/node/-/node-24.12.2.tgz#353cb161dbf1785ea25e8829ba7ec574c5c629ac"
integrity sha512-A1sre26ke7HDIuY/M23nd9gfB+nrmhtYyMINbjI1zHJxYteKR6qSMX56FsmjMcDb3SMcjJg5BiRRgOCC/yBD0g==
dependencies:
undici-types "~7.16.0"

"@types/nodemailer@^6.4.0":
version "6.4.0"
Expand Down Expand Up @@ -27166,6 +27168,11 @@ underscore@1.x:
resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.9.2.tgz#0c8d6f536d6f378a5af264a72f7bec50feb7cf2f"
integrity sha512-D39qtimx0c1fI3ya1Lnhk3E9nONswSKhnffBI0gME9C99fYOkNi04xs8K6pePLhvl1frbDemkaBQ5ikWllR2HQ==

undici-types@~7.16.0:
version "7.16.0"
resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-7.16.0.tgz#ffccdff36aea4884cbfce9a750a0580224f58a46"
integrity sha512-Zz+aZWSj8LE6zoxD+xrjh4VfkIG8Ya6LvYkZqtUQGJPZjYl53ypCaUwWqo7eI0x66KBGeRo+mlBEkMSeSZ38Nw==

undici@^4.9.3:
version "4.12.2"
resolved "https://registry.yarnpkg.com/undici/-/undici-4.12.2.tgz#f2fc50ca77a774ed8c0e7067c9361ee18a2f422b"
Expand Down
Loading