Repository navigation
Conversation
Collaborator
|
Don't worry about the FS ones, we only added those cause they were our employer at the time. Is this PR ready to merge and does the other one still apply too? |
Contributor
Author
|
Hold off on this one until I check Sophos. I have a bunch of samples from prior cases just have to dig them up first. |
Contributor
Author
|
@alexkornitzer This is done and the fix has been validated on Sophos. With the #text fix it is an exact match to the older version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes most of the Antivirus rules. I still need to test Sophos from event log samples I have. I do not have access to F-Secure Ultralight SDK Event.System.Provider logs so can't validate the F-Secure Antivirus one. Had samples of the legacy versions hence fixing the f-secure_legacy.yml one. windows_defender did not require any fixes and can remain as it is