Pin verbatim export of snippet and Blueprint source - #285
Open
sirreal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settles a policy question left open during the #262 rebase: after the targeted redesign of global-name prefix stripping,
doc.code_snippets[].code/expected_outputandsetup_blueprintsreceive no stripping at all — master's blanketarray_walk_recursiveused to touch them. That is the correct behavior — snippets and Blueprint definitions are executable, verbatim source, not prose — but nobody had stated it or pinned it.This adds a fixture whose snippet code, expected output, and Blueprint
writeFiledata all contain\-qualified global names, and asserts they export exactly as authored.The test passes on
fix-254. The same test run against master fails: the blanket walk rewrites the snippet toecho Docs_Global::greet();and the expected output toHello from Docs_Global— demonstrating that the pin captures a real difference in #262's behavior, not a tautology. (Master happens to leave this particular Blueprint data alone because its backslashes follow a newline and a quote rather than a space — which only underlines how incidental the old stripping was.)Targets
fix-254to land with #262.🤖 Generated with Claude Code