Repository navigation
Conversation
pfefferle
left a comment
There was a problem hiding this comment.
Can you make it configurable by supporting the env var WPT_DEBUG?
https://github.com/WordPress/phpunit-test-runner/blob/master/.env.default#L62
You see an example here:
phpunit-test-runner/prepare.php
Line 33 in 6fc0d25
|
I wonder if we still need this since #222 was solved with #225? If we still want it, I like the idea of making it configurable via |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Okay, this needs further discussion.
|
|
Picking up the questions above:
|
* Run npm verbosely when debug mode is enabled When an npm command hangs or misbehaves during preparation, the runner shows nothing that explains where it is stuck. Append --loglevel=silly to the npm install and build commands when WPT_DEBUG is set, matching how debug mode already adds verbosity to the rsync operations. Default behavior is unchanged. Based on the approach in #221 by @rollecode, updated to gate the verbosity behind WPT_DEBUG as suggested in the review discussion. * Move the npm verbosity setup above the checkout comment block Keeps the existing block attached to the perform_operations() call it describes and uses the file's multi-line comment style, as suggested in review. --------- Co-authored-by: Amy Kamala <39748136+kittenkamala@users.noreply.github.com>
This adds verbose debug flags in case of npm commands hang or behave unexpectedly.