Repository navigation
[TASK] first attempt to reduce NPM need bu using the Core nightly bui… - #246
ramonfincken wants to merge 1 commit into
Conversation
…ld as source of truth for CSS and JS files
|
Perhaps I'm missing something. But why can't the test runner just use the https://github.com/WordPress/WordPress repository instead of the nightly? Using the nightly loses a level of fidelity because you can't control which commit is tested. But the WordPress SVN repository is updated by the build server after every commit to wordpress-develop and mirrored here to GitHub. The only challenge there is a search would need to be performed to find the corresponding changeset. |
|
The point is to copy the nightly JS/CSs files, not the PHP ones. But hold on, i will try using another path. |
|
Thanks for your talk at WordCamp by the way :) |
|
Picking this up, thanks Ramon for the first attempt. The original direction here still makes sense, but the implementation needs a different shape now. #246 still runs The alternative desrosj suggested looks viable: the WordPress/WordPress built mirror carries the exact develop revision in each commit message ( Plan: a new opt-in I will push the new approach to this PR, with a same-revision comparison of the npm route and the mirror route. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ramon@creativepulses.nl. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
first attempt to reduce NPM need bu using the Core nightly build as source of truth for CSS and JS files