Skip to content

Backport: Skip pull_request triggered runs in private repos - 5.1 Branch - #13000

Draft
desrosj wants to merge 1 commit into
WordPress:5.1from
desrosj:backport/5.1-branch-63183
Draft

Backport: Skip pull_request triggered runs in private repos - 5.1 Branch#13000
desrosj wants to merge 1 commit into
WordPress:5.1from
desrosj:backport/5.1-branch-63183

Conversation

@desrosj

@desrosj desrosj commented Aug 12, 2026

Copy link
Copy Markdown
Member

This backports 15c4b04 (r63183) to the 5.1 branch.

Merge Conflict Resolution

The direct git cherry-pick of 15c4b04 produced conflicts in every touched file and wanted to (re)create several workflow files that do not exist on the 5.1 branch (git-svn history renamed/restructured many workflow files between 5.1 and trunk). The cherry-pick was aborted and the change was applied by hand, file by file, preserving the original commit message.

The 5.1 branch only has 4 files under .github/workflows/: coding-standards.yml, javascript-tests.yml, phpunit-tests.yml, and test-build-processes.yml. Each was checked for jobs using the if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }} gate and updated in place to the canonical replacement:

    if: |
      github.repository == 'WordPress/wordpress-develop' || (
        github.event_name == 'pull_request' && (
          ! github.event.repository.private ||
          ! github.event.pull_request.draft ||
          contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
        )
      )

Jobs updated:

  • .github/workflows/coding-standards.yml: phpcs and jshint jobs.
  • .github/workflows/javascript-tests.yml: test-js job.
  • .github/workflows/phpunit-tests.yml: test-php job (this branch has a single PHP/MySQL test job, not the per-combination matrix jobs added later on trunk, so there was only one job to update here).
  • .github/workflows/test-build-processes.yml: test-core-build-process job. The test-core-build-process-macos job in the same file was intentionally left untouched — its condition is only github.repository == 'WordPress/wordpress-develop' (no || github.event_name == 'pull_request' clause), so it is not part of the affected family and was out of scope.

Files from the original commit that do not exist on the 5.1 branch and were therefore skipped entirely (not created): end-to-end-tests.yml, javascript-type-checking.yml, performance.yml, php-compatibility.yml, phpstan-static-analysis.yml, test-and-zip-default-themes.yml, upgrade-develop-testing.yml, workflow-lint.yml. None of these have an equivalent under a different name on this branch.

The slack-notifications and failed-workflow jobs in each of the 4 files were left untouched, as they are gated on github.event_name != 'pull_request' and are unaffected by this change.

No files outside .github/workflows/ were touched.

Use of AI Tools

This pull request was created by an AI agent (Claude Code). Until this PR is marked "Ready for Review", treat it as untrusted, AI-created code that requires a manual review by a human team member.

This modifies the conditions for GitHub Actions workflow runs so that they do not run within private forks and mirrors for `pull_request` events when the PR is in `draft` status.

For situations where this may be desirable, a `Draft Workflow Runs` label can be added to a `draft` pull request to force workflows to run.

Props desrosj, jorbin.
See #65848.
@desrosj desrosj self-assigned this Aug 12, 2026
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant