REST API: Prevent taxonomy REST bases from overwriting post item properties - #13013
Open
csergozoltan wants to merge 1 commit into
Open
REST API: Prevent taxonomy REST bases from overwriting post item properties#13013csergozoltan wants to merge 1 commit into
csergozoltan wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
csergozoltan
force-pushed
the
65855-rest-taxonomy-property-collision
branch
from
August 12, 2026 10:20
a832668 to
124936d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/65855
This PR prevents taxonomies with conflicting REST bases from overwriting existing post item properties.
The existing
_doing_it_wrong()warning added for #48401 is preserved, but conflicting taxonomies are excluded from the item-level REST taxonomy set so they no longer participate in:The conflict-free taxonomy list is initialized while building the item schema and reused by the relevant item-level paths. This avoids lazily calling
get_item_schema()from the helper, which could introduce recursion in subclasses such asWP_REST_Menu_Items_Controller.Collection-level taxonomy query behavior is intentionally unchanged.
Tests added for:
typeschema property when a taxonomy name conflicts;typeresponse property;WP_REST_Menu_Items_Controllersubclass schema path.Testing:
npm run test:php -- --group 65855npm run test:php -- --filter WP_Test_REST_Posts_Controllernpm run test:php -- --filter Tests_REST_WpRestMenuItemsControllergit diff --checkreports no whitespace errors.