Skip to content

Code Modernization: Use is_iterable() instead of manual array or Traversable checks - #13016

Open
Soean wants to merge 1 commit into
WordPress:trunkfrom
Soean:code-quality/is-iterable-ai-client-http-client
Open

Code Modernization: Use is_iterable() instead of manual array or Traversable checks#13016
Soean wants to merge 1 commit into
WordPress:trunkfrom
Soean:code-quality/is-iterable-ai-client-http-client

Conversation

@Soean

@Soean Soean commented Aug 12, 2026

Copy link
Copy Markdown
Member

Description

PHP offers is_iterable() for the "array or Traversable" test that is otherwise written as a compound condition:

// Before
if ( is_array( $value ) || $value instanceof Traversable ) {

// After
if ( is_iterable( $value ) ) {

This replaces that idiom where it occurs.

Why this is safe

is_iterable() returns true for arrays and for objects implementing Traversable, and false for everything else, the same set the compound condition described, with no edge cases in between. It has been available since PHP 7.1, and WordPress currently requires PHP 7.4 or greater, so no compatibility shim is needed. Only the conditions themselves change; no surrounding logic is touched.

Trac ticket:


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…raversable` checks.

`is_iterable()` returns true for arrays and `Traversable` instances and nothing else, so it is an exact replacement for the compound `is_array() || … instanceof Traversable` condition. It has been available since PHP 7.1, well below the current minimum requirement of PHP 7.4.

Sites where a `Traversable` check is a distinct branch with its own handling, such as the `iterator_to_array()` branch in `wp_insert_user()`, are intentionally left unchanged.
@github-actions

Copy link
Copy Markdown

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props soean.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant