Code Modernization: Use is_iterable() instead of manual array or Traversable checks - #13016
Code Modernization: Use is_iterable() instead of manual array or Traversable checks#13016Soean wants to merge 1 commit into
Conversation
…raversable` checks. `is_iterable()` returns true for arrays and `Traversable` instances and nothing else, so it is an exact replacement for the compound `is_array() || … instanceof Traversable` condition. It has been available since PHP 7.1, well below the current minimum requirement of PHP 7.4. Sites where a `Traversable` check is a distinct branch with its own handling, such as the `iterator_to_array()` branch in `wp_insert_user()`, are intentionally left unchanged.
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Description
PHP offers
is_iterable()for the "array orTraversable" test that is otherwise written as a compound condition:This replaces that idiom where it occurs.
Why this is safe
is_iterable()returnstruefor arrays and for objects implementingTraversable, andfalsefor everything else, the same set the compound condition described, with no edge cases in between. It has been available since PHP 7.1, and WordPress currently requires PHP 7.4 or greater, so no compatibility shim is needed. Only the conditions themselves change; no surrounding logic is touched.Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.