Editor: Drop mixed-unit viewport breakpoint pairs in theme.json - #13029
Editor: Drop mixed-unit viewport breakpoint pairs in theme.json#13029itzmekhokan wants to merge 1 commit into
Conversation
A `settings.viewport` pair that mixes a relative `em`/`rem` breakpoint with an absolute `px` one is ordered against a fixed 16px base, but the generated media query keeps the original units. Because a media query resolves `em` and `rem` against the browser's default font size, the emitted `@tablet` range inverts into an empty range for readers who change that default, silently dropping the responsive styles and viewport visibility rules bound to it. Remove `tablet` when it does not share an absolute or relative unit type with `mobile`, alongside the existing check that removes it when it is not larger than `mobile`. Pairs that mix `em` and `rem` are kept, since a media query resolves both against the same base. Fixes #65865.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
A
settings.viewportpair that mixes units, such as"mobile": "30em"with"tablet": "580px", produces an empty@tabletmedia query for readers who change their browser's default font size, so the responsive styles and visibility rules bound to it silently stop applying.sanitize_viewport_settings()orders the pair against a fixed 16px base, but the generated query keeps the original units, and a media query resolvesem/remagainst the reader's default font size instead. The patch removestabletwhen it does not share an absolute or relative unit type withmobile, alongside the existing not-larger-than check.em/rempairs are kept, since a media query resolves both against the same base; same-unit and default pairs are unaffected.Trac ticket: https://core.trac.wordpress.org/ticket/65865
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Diagnosing the unit-resolution mismatch, drafting the fix and its unit tests. All changes were reviewed and validated by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.