Conversation
Signed-off-by: predutta <predutta@amd.com>
predutta
requested review from
jvillarre
and
a balanced review from Copilot
September 30, 2026 21:46
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Trace consumers still read PLIO names by logical channel slot, so nonzero stream IDs can remain "unused".
Review effort: Balanced
Findings: 1
What changed in this PR
Populates PLIO names for interface-tile trace reporting.
Changes:
- Indexes PLIO names by stream ID and GMIO names by DMA channel.
| File | Description |
|---|---|
profile/database/static_info/filetypes/aie_control_config_filetype.cpp |
Extends MM2S/S2MM name population to PLIOs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // Populate mm2s_names/s2mm_names for SelTraceConfig (hwanalyze uses these, | ||
| // not PortTraceConfig.names). GMIO is indexed by DMA channel; PLIO by streamId. | ||
| { | ||
| uint8_t nameIdx = (type == io_type::GMIO) ? channelNum : streamId; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populate mm2s_names/s2mm_names for PLIO interface tiles (indexed by stream ID), so SelTraceConfig in aie_event_runtime_config carries the real port names instead of "unused" and hwanalyze stops falling back to default port names for mm2s_ports/s2mm_ports trace.
Tested on aie1 (vck190) with (tile_based_interface_tile_metrics=all:mm2s_ports) in xrt.ini . Diffing aie_event_runtime_config_0.json before and after the fix, the only changes are the four traced interface tiles (22,0), (23,0), (26,0) and (28,0): mm2s_names[0] went from "unused" to G.in[2], G.in[1], G.in[0] and G.in[3]. Each name matches the input PLIO for that column in the design's aie_control_config.json. All other entries, including the AIE-tile all_stalls blocks, were unchanged.