Repository navigation
fix: preserve vault settings and warn before registry edits - #141
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A running Obsidian process can overwrite external vault registrations when its window reopens. Warn before
add-vaultandremove-vaultwrite the registry, and document in command help and the README that Obsidian must be fully quit, including Cmd+Q on macOS. Send warnings to stderr so existing stdout remains unchanged. These commands remain available for headless use; this does not detect or synchronize with a running Obsidian process.Also preserve unknown top-level settings and per-vault metadata when adding or removing registrations. Previously, rewriting the path-only config structure discarded those fields. Preserve raw JSON values, including large numbers.
Validation:
go.modnow requires Go 1.26.1, which fixes GO-2026-4602 reported by the shared Security check on Go 1.26.0.go test -race ./...passes, including add/remove round trips with nested metadata and large integers, and missing/null vault maps.golangci-lintv2.10.1 reports no issues.go mod verifypasses.Fixes #138.