Repository navigation
fix: fill template variables in daily notes - #144
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
Since daily writes the note itself (Yakitrak#90), the template was copied as is, so {{date}}, {{title}} and {{time}} stayed literal. Fill them the way Obsidian's daily notes plugin does: {{date}} and {{title}} are the note name, {{time}} is HH:mm, and {{date:FORMAT}}/{{time:FORMAT}} take a Moment.js format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dailycopies the daily-note template as it is, so{{date}},{{title}}and{{time}}stay literal in every note it creates:The template is now filled in the way Obsidian's daily notes plugin does it:
{{date}}and{{title}}are the note name,{{time}}isHH:mm, and{{date:FORMAT}}/{{time:FORMAT}}take a Moment.js format (through the existingMomentToGoFormat).Motivation and Context
Before #90,
dailyopenedobsidian://dailyand Obsidian filled the variables. Sincedailywrites the file itself, a template with a date heading or a{{date}}property gives a note with placeholders, and tools that read the property (Dataview, Properties) get the literal text.Checklist:
Added "Fills template variables" to
TestDailyNote; it fails without the change.go test ./...passes. Ran the steps above with a built binary on a scratch vault.