Repository navigation
MIT-618: tidy two GitHub-task cause-word notes (batch 9, no new tasks) - #173
Merged
Merged
Conversation
Drop the validate-by-name task's cause words that name no change to
pydantic's object ("leaves model_config", "model_config unchanged",
bare "no longer mutates"), and say that every phrase but the version
carries its object. In the table-extraction task, the reason to leave
out a bare "boolean form field" is that a symptom-only fix says it;
the test names use underscores, so grading can't match them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qc1CQTb8r67J32HpkhS43y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR is the cleanup commit in
tools/eval/github_tasks.py. It adds 0 new GitHub tasks, so the file still holds 9. Zach wants 20. Batch 9 covered developer tooling and packaging. I hit the turn budget with no candidate that met the bar; see the rejected candidates.The cleanup
gh-pydantic-settings-validate-by-name:leaves model_config,model_config unchangedand the bareno longer mutates. Keptno longer mutates model_config.model_configorvalidate_by_name, and the only exception is2.14.gh-table-extraction-bool-form: the comment no longer says the laid-over test names "say" "boolean form field". The names use underscores, so grading can't match them. The reason given now is that a fix treating only the symptom says it ("parse the boolean form field and apply its default").No other line in the file changed.
New tasks
None. Pairs: 0. New version words: none. The expected set in
test_the_cause_words_grader_v2_skips_are_exactly_the_versionsis unchanged.Rejected candidates (this batch)
allow_editableson the preparer, merged 2026-07-27) and pip#14133 (stdlib_pkgsmoved, merged 2026-07-02). This was the closest miss:test_cli_compile.pytests fail at the base withTypeError: RequirementCommand.make_requirement_preparer() missing 1 required keyword-only argument: 'allow_editables'and pass at the fix.test_compile_with_generate_hashes_preserves_extra_index_urlandtest_name_collisionneed the network: theminimal_wheels_pathfixture and build deps download setuptools.test_package_findertest imports the fix's new helper, so it fails at the base on any pip.Requirement): the new tests' comments state the cause (pickling throughstr(self)). The fix's own comments attribute the change to packaging 25 and 26.2, not 26.3.src/change is a comment, so in effect it changes only tests.BuildHookInterface): the fix's only test change is a module-level skip. TheTypeErrorfrom subscripting names its fix.NDArray(2026-06-21, before the cutoff, and scientific).sort_keys): the fix changes no test.is_subhint(Any, T) == Truebreaks plum's method-redefinition detection, silently deleting registered methods beartype/plum#295 (beartype 0.23is_subhint(Any, T)): not pursued. The issue (2026-08-11) and fix (2026-09-03) came after 0.23.0rc0 (2026-08-08) but before 0.23.0 final (2026-10-10).Why
This is the batch-9 slice of
MIT-618, the GitHub-task eval. The cleanup makes two task records' notes match the cause-word rules the reviews settled on.How it was tested
server/tests/test_eval_grader.pyandserver/tests/test_eval_repos.pypass, 109 tests.make checkpasses aftergit merge origin/feature/eval-setup, which was already up to date.agent_eval.py checkruns, through a.scratch/helper callingrepos.materialize,repos.prepareandrepos.run_testswithcontainer.run. Containers ran one at a time, none were left behind, and--on-hostwas never used.Learned
pip_conf,pip_with_index_confandminimal_wheels_pathfixtures download setuptools from PyPI at session start, so any test that uses them fails under--network none. Plainrunnercompile tests with--no-indexrun offline."hatchling 1.32" in:titlefinds nothing, while"hatchling 1.32.3" in:title,bodyfinds the issues. Search the full patch version, and search bodies too.ghwith a loop variable. Put repeatedgh apicalls in a.scratch/helper run withpython3 -I.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qc1CQTb8r67J32HpkhS43y