Skip to content

feat(zlinter): enable no_orelse_unreachable - #1121

Open
vesim987 wants to merge 3 commits into
mainfrom
zlinter-no-orelse-unreachable
Open

vesim987 wants to merge 3 commits into
mainfrom
zlinter-no-orelse-unreachable

Conversation

@vesim987

@vesim987 vesim987 commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Stack created with GitHub Stacks CLI • Give Feedback 💬

@vesim987
vesim987 added this pull request to stack #1123 November 5, 2026 23:41

@Grazfather Grazfather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is actually uglier than I expected with

-var bla = try x() orelse unreachable;
+var bla = (try x()).?;

Still OK with it

@mattnite
mattnite force-pushed the zlinter-no-orelse-unreachable branch from 8482d3b to f14fb74 Compare November 7, 2026 14:33
@vesim987
vesim987 removed this pull request from stack #1123 November 7, 2026 22:29
@vesim987
vesim987 force-pushed the zlinter-no-orelse-unreachable branch from f14fb74 to d6eb498 Compare November 7, 2026 22:29
@vesim987
vesim987 changed the base branch from zlinter-no-redundant-comptime to zlinter-no-literal-only-bool-expression November 7, 2026 22:29
@vesim987
vesim987 added this pull request to stack #1126 November 7, 2026 22:29
@vesim987
vesim987 force-pushed the zlinter-no-orelse-unreachable branch from d6eb498 to 6d954ab Compare November 7, 2026 22:32
@vesim987
vesim987 removed this pull request from stack #1126 November 7, 2026 22:47
@vesim987
vesim987 force-pushed the zlinter-no-literal-only-bool-expression branch from 534e91d to 8414fcd Compare November 7, 2026 22:52
@vesim987
vesim987 changed the base branch from zlinter-no-literal-only-bool-expression to main November 7, 2026 22:53
@vesim987
vesim987 force-pushed the zlinter-no-orelse-unreachable branch from 6d954ab to 12861cf Compare November 7, 2026 22:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants