[Fix] Provider settings contact unselected model services - #1425
[Fix] Provider settings contact unselected model services#1425zoomote[bot] wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: Awaiting fresh human maintainer or CODEOWNER approval. Review-state labels are managed by this workflow; do not edit them manually. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughProvider settings now fetch router models only for the selected dynamic provider. Provider refresh messages include explicit provider identifiers. Tests cover provider filtering and refreshed request payloads. ChangesProvider model loading
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Provider model discovery is now scoped to the selected provider while local providers retain their dedicated refresh paths; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 11 files. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
webview-ui/src/components/settings/ApiOptions.tsxESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. webview-ui/src/components/settings/__tests__/ApiOptions.interactions.spec.tsxESLint skipped: the matched ESLint configuration already failed (missing-dependency). webview-ui/src/components/settings/__tests__/ApiOptions.provider-filtering.spec.tsxESLint skipped: the matched ESLint configuration already failed (missing-dependency).
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4dc95e6 to
7a3e6f1
Compare
What changed
Provider settings now scope dynamic model discovery to the provider the user selected. Automatic and manual refresh paths for LiteLLM, Poe, and Moonshot include explicit provider filters, while Ollama and LM Studio no longer fall through to aggregate router discovery.
Regression coverage verifies static, dynamic, local, automatic-refresh, and manual-refresh paths. The branch was rebased onto the latest
main, and the test imports and provider identifiers were corrected so the current compile, lint, type-check, and test gates pass locally.Why this change was made
Opening provider settings could contact optional model services that the user had not selected, including Kenari. Scoping discovery avoids unexpected third-party connections and limits model-catalog traffic to the provider being configured.
Closes #1424.
Impact
Users no longer contact unrelated model providers while configuring another provider. Selecting a dynamic provider still loads that provider's current model catalog, and local/manual refresh behavior remains available.
Related PRs