Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pythonlings/core/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,18 @@ def run(exercise: Exercise, timeout_s: float = DEFAULT_TIMEOUT_S) -> RunResult:
"PYTHONDONTWRITEBYTECODE": "1",
"PYTHONIOENCODING": "utf-8",
}
exercise_src = exercise_path.read_text(encoding="utf-8")
try:
exercise_src = exercise_path.read_text(encoding="utf-8")
except UnicodeDecodeError as e:
return RunResult(
passed=False,
exit_code=-1,
stdout="",
stderr=f"pythonlings: exercise is not valid UTF-8: {e}",
duration_s=0.0,
timed_out=False,
)

runner_src = (
"import sys\n"
"from pathlib import Path\n"
Expand Down
25 changes: 25 additions & 0 deletions tests/unit/test_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,31 @@ def test_utf8_output(tmp_path: Path) -> None:
assert "héllo 🐍" in result.stdout


def test_invalid_utf8_exercise_returns_failure_not_raise(tmp_path: Path) -> None:
# Regression for #72: an invalidly encoded exercise must not escape
# run()'s no-raise contract as UnicodeDecodeError.
ex_path = tmp_path / "exercise.py"
check_path = tmp_path / "check.py"
ex_path.write_bytes(b'x = "\xff"\n')
check_path.write_text("assert True\n", encoding="utf-8")

result = run(
Exercise(
name="invalid-utf8",
path=ex_path,
check_path=check_path,
topic="t",
hint="",
root=tmp_path,
)
)

assert result.passed is False
assert result.exit_code != 0
assert "not valid UTF-8" in result.stderr
assert result.timed_out is False


def test_runner_uses_workspace_for_relative_files(tmp_path: Path) -> None:
data_path = tmp_path / "data.txt"
data_path.write_text("pythonlings\n", encoding="utf-8")
Expand Down
Loading