deal with path being empty : working from root of drive_id#11
Open
xavier-bouquiaux wants to merge 1 commit into
Open
deal with path being empty : working from root of drive_id#11xavier-bouquiaux wants to merge 1 commit into
xavier-bouquiaux wants to merge 1 commit into
Conversation
if i try to leave the fs_storage.directory_path empty, those lines are in error
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=======================================
Coverage 33.22% 33.22%
=======================================
Files 2 2
Lines 963 963
Branches 167 167
=======================================
Hits 320 320
Misses 623 623
Partials 20 20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if i try to leave the fs_storage.directory_path empty, those lines are in error
I tried locally and those 2 small changes works