Skip to content

fix: filter add-member username candidates to normal users - #886

Merged
LordofAvernus merged 1 commit into
mainfrom
dms-ui/fix-973
Aug 21, 2026
Merged

fix: filter add-member username candidates to normal users#886
LordofAvernus merged 1 commit into
mainfrom
dms-ui/fix-973

Conversation

@LordofAvernus

Copy link
Copy Markdown
Collaborator

关联的 issue

https://github.com/actiontech/dms-ee/issues/973

描述你的变更

  • Pass filter_by_stat=Normal in base useUsername when calling ListUsers so add-member (and shared) pickers only list normal users
  • Extend unit test to assert the filter parameter

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

Made with Cursor

Pass filter_by_stat=Normal in useUsername ListUsers so disabled and
deleted users are not offered in project member pickers.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 80.59% 30293/37589
🟡 Branches 62.9% 11417/18150
🟢 Functions 83.98% 10188/12131
🟢 Lines 84.43% 28956/34297

Test suite run success

3774 tests passing in 825 suites.

Report generated by 🧪jest coverage report action from e7e2ca4

@LordofAvernus
LordofAvernus merged commit a4c4a59 into main Aug 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant