fix(schema): align brand property type enums - #6334
Conversation
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated schema paths require human/CODEOWNERS review.
This PR modifies published protocol source under static/schemas/source/** (a hard-gated path), and review_decision is REVIEW_REQUIRED — not APPROVED. Per decision rule row 2, the gate is not satisfied and the outcome must be escalate.
The change itself looks clean per the reviewer: it aligns brand property.type across brand.json and the two verify-brand-claim request schemas by $ref'ing the canonical property-type enum (adding linear_tv and ai_assistant), updates all three doc surfaces to match, ships a correct minor changeset, and adds a test covering every canonical value plus a negative case. The reviewer reports schema↔docs coherence holds and the change is additive/Normative (non-breaking), with no findings. But no blocking findings does not lift the deterministic path gate — only a real APPROVED review does.
Escalation reasons
- Modifies gated schema source
static/schemas/source/brand.json,static/schemas/source/brand/verify-brand-claim-request.json, andstatic/schemas/source/brand/verify-brand-claims-request.json;review_decisionisREVIEW_REQUIRED. Human/CODEOWNERS approval is required before merge.
Why human review
- Modifies gated schema source under static/schemas/source/** (brand.json, verify-brand-claim-request.json, verify-brand-claims-request.json) while review_decision is REVIEW_REQUIRED — human/CODEOWNERS approval required (decision rule row 2).
- This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/brand.json (modified) matches
static/schemas/source/**; static/schemas/source/brand/verify-brand-claim-request.json (modified) matchesstatic/schemas/source/**; static/schemas/source/brand/verify-brand-claims-request.json (modified) matchesstatic/schemas/source/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
Summary
linear_tvandai_assistantvalidate consistentlyFixes #6330
Testing
npm run build:schemasnpm run test:schemas(29 schema checks and 4 metadata checks passed)node scripts/check-changeset-protocol-scope.cjs origin/mainnpx --yes @changesets/cli@^2.31.0 status --since=origin/maingit diff --check origin/main...HEADRelease
Includes a minor
adcontextprotocolchangeset because the published schemas gain two existing canonical enum values.