feat: derive source contentUrl from DA_CONTENT env var - #312
Merged
Conversation
The contentUrl in the source response was hardcoded to https://content.da.live. On stage/ci/dev/it the worker should point to https://stage-content.da.live instead. Add a DA_CONTENT var per wrangler environment (production = content.da.live, all others = stage-content.da.live) and thread env into sourceRespObject so the base URL comes from config. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tripodsan
approved these changes
Aug 7, 2026
adobe-bot
pushed a commit
that referenced
this pull request
Aug 7, 2026
# [1.15.0](v1.14.1...v1.15.0) (2026-08-07) ### Features * derive source contentUrl from DA_CONTENT env var ([#312](#312)) ([11e926f](11e926f))
3 tasks
Collaborator
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
contentUrlreturned in the source response was hardcoded tohttps://content.da.live. When the worker runs on stage/ci/dev/it, it should point tohttps://stage-content.da.live.Changes
DA_CONTENTvar to everywrangler.tomlenvironment:production→https://content.da.livestage/ci/dev/it→https://stage-content.da.liveenvintosourceRespObject(env, daCtx)socontentUrlis built fromenv.DA_CONTENT.DA_CONTENTto theEnvtype and the test env mock.sourceRespObject; update the IT assertion tostage-content.da.live.Note: only
contentUrlchanged —editUrlstill points toda.live.🤖 Generated with Claude Code