fix(data): observeSelectDeep dropped entity id when include carried the id column

[krisnye]

Problem

observeSelectDeep returns rows with id: undefined whenever the include set carries the id column — which an archetype's runtime components set does, and which real consumers pass directly (e.g. observeSelectDeep(db, db.archetypes.Foo.components)).

pickComponents seeded data.id = entity, then copied every include key from the read values:

const data = { id: entity };
for (const key of includeKeys) data[key] = values[key]; // data["id"] = values["id"]

Since the id-removal change made reads omit id, values["id"] is undefined, and the loop overwrites the correct id. Before id-removal this was masked (the read still carried the right id, so the overwrite was a no-op).

Impact

Any consumer that keys off row.id from a deep select silently gets undefined. This surfaced as a studio layout regression in firefly-platform: the layout system feeds row.id into a per-entity setLayoutIntrinsic transaction; with id undefined the transaction no-ops, so measured element sizes are never recorded, the layout never converges, and top-bar/sidenav controls never settle — breaking three P0 studio E2E tests. Verified end-to-end that this fix resolves them.

Fix

Skip "id" in the copy loop and assign data.id = entity last, so the id column present in the include set can't clobber it. Regression test drives include straight off archetype.components (which carries the id column) — the old tests passed an explicit array without id, so they missed it.

Full data suite green (3023); typecheck clean.

🤖 Generated with Claude Code