Repository navigation
SCIX-942 fix(author-affiliation): download Excel export as binary - #951
Open
thostetler wants to merge 1 commit into
Open
thostetler wants to merge 1 commit into
thostetler wants to merge 1 commit into
Conversation
Axios decoded the OLE2 response as UTF-8 and useDownloadFile re-encoded it, replacing every invalid byte sequence with U+FFFD. Request the two [excel] formats as arraybuffer and widen useDownloadFile to accept BlobPart. jsdom's XHR corrupts binary the same way, so tests pin axios' fetch adapter; the browser path was verified by hand against the live API.
Bundle sizeShared by all pages: 627.7 kB (+0.0 kB) ⚪ No route changed by more than 1 kB. ✅ First load = polyfills + shared |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
========================================
- Coverage 55.2% 55.2% -0.0%
========================================
Files 378 379 +1
Lines 11618 11643 +25
Branches 2554 2554
========================================
+ Hits 6406 6416 +10
- Misses 4574 4586 +12
- Partials 638 641 +3
🚀 New features to boost your workflow:
|
thostetler
marked this pull request as ready for review
October 16, 2026 05:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author-affiliation Excel export downloaded a file Excel refused to open, because axios decoded the binary response as UTF-8 text before it reached the browser.