Repository navigation
Support practitioner launch context in questionnaire test toolkit - #2193
Draft
pavlushkin wants to merge 3 commits into
Draft
pavlushkin wants to merge 3 commits into
pavlushkin wants to merge 3 commits into
Conversation
Add optional user and fhirContext inputs to BehavioralTestWrapper, forward them through population and renderer context, and rerun population when either changes. Make selectTab idempotent for an already-expanded accordion. Bump the package to 0.1.1 and document the population contract. The packed artifact passes strict ESM/CJS declaration checks and eight external-consumer acceptance cases; the 26-test Aboriginal extraction suite also passes. Forward-ports c1c1c4d
Collaborator
|
Thanks @pavlushkin - could we start a CHANGELOG.md for this package? |
Contributor
Author
|
Hi Leonie,
Sure, I will all soon.
…On Mon, 26 Oct 2026 at 15:23, leoniedickson ***@***.***> wrote:
*leoniedickson* left a comment (aehrc/smart-forms#2193)
<#2193 (comment)>
Thanks @pavlushkin <https://github.com/pavlushkin> - could we start a
CHANGELOG.md for this package?
—
Reply to this email directly, view it on GitHub
<#2193?email_source=notifications&email_token=AHSGO26WJDWQ6H3CD24C43L5V3UX3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBQHE3DKNJXGYYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6409655760>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHSGO2Y6YLMI77UJOVLTZO35V3UX3AVCNFSNUABFKJSXA33TNF2G64TZHM2DONZUHA3DONRZHNEXG43VMU5TMMBTGM4TMMRXGI32C5QC>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
Follow-up toolkit PR (saved responses, comparison extraction, strict interaction guards, population callback seam, repeat helpers and Health Check acceptance) opened against this branch: beda-software#27. It will be retargeted to |
Contributor
Author
|
Follow-up toolkit PR (saved responses, comparison extraction, strict interaction guards, population callback seam, repeat helpers and Health Check acceptance): #2194 — built on top of this branch and will be rebased onto |
pavlushkin
marked this pull request as draft
October 27, 2026 09:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GP CCMP population tests need practitioner and PractitionerRole launch context, but published
@aehrc/questionnaire-test-toolkit@0.1.0accepts only patient context. This change adds the missing inputs so the suite can run from the IG repository using the published toolkit.Changes
userandfhirContextwrapper props; forward them to population, expose the practitioner to renderer expressions, and repopulate when either input changes.selectTableave an already expanded accordion open while preserving normal clicks for other tabs.0.1.1, keeping the existing renderer and SDC dependency baseline and dual ESM/CJS package exports.The context rerender test keeps the same request-definition array across renders and changes only
fhirContext. The fixtures have no external ValueSets, so these regression tests do not depend on Ontoserver.Validation
userdependency, removing thefhirContextdependency, and removing the expanded-tab guard. The original build was restored and the normal suite passed again.Release dependency
This is the toolkit prerequisite for aehrc/gpccmp-fhir-ig#8. Merging this PR does not publish a package: a maintainer must release
questionnaire-test-toolkit@0.1.1through the existing release workflow. After publication, the IG lockfile must be regenerated from npm and the actual registry artifact, clean installation, 41-test suite and CI verified. The earlier packed candidate integrity must not be assumed to match the final published tarball.