Skip to content

Keep public toolsets skill-first#2979

Open
louis4li wants to merge 2 commits into
feature/integratefrom
fix/2026-07-27_skill-first-public-toolsets
Open

Keep public toolsets skill-first#2979
louis4li wants to merge 2 commits into
feature/integratefrom
fix/2026-07-27_skill-first-public-toolsets

Conversation

@louis4li

Copy link
Copy Markdown
Contributor

Summary

  • Move Studio provisioning/member/query/bind/schedule tool sources out of workspace.default into explicit studio.local.
  • Keep Lark/channel/default paths on the sanitized workspace toolset instead of ambient Studio-local IAgentToolSource registrations.
  • Add composition assertions covering workspace.default, lark.self_notify, global agent tool sources, channel reply sources, and studio.local.

Test plan

  • dotnet test test/Aevatar.Capabilities.Tests/Aevatar.Capabilities.Tests.csproj --filter MainnetHostCompositionTests --nologo --verbosity minimal
  • dotnet test test/Aevatar.AI.Tests/Aevatar.AI.Tests.csproj --filter NyxIdChatServiceCollectionExtensionsTests --nologo --verbosity minimal
  • bash tools/ci/architecture_guards.sh incomplete locally: Python failed loading pyexpat/libexpat in project_reference_layer_guard.py after earlier guards passed.

Fixes #2975

🤖 Generated with Claude Code

Move Studio-local provisioning tools behind an explicit studio.local toolset so public/default and Lark/channel paths use the sanitized workspace toolset.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@louis4li
louis4li requested a review from jason-aelf as a code owner July 27, 2026 04:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7d0bf9e91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.24390% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.20%. Comparing base (900ced5) to head (25ae3fc).
⚠️ Report is 9 commits behind head on feature/integrate.

Files with missing lines Patch % Lines
...w.Integration.AI/AgentWorkflowToolSourceAdapter.cs 90.24% 1 Missing and 11 partials ⚠️
@@                  Coverage Diff                  @@
##           feature/integrate    #2979      +/-   ##
=====================================================
+ Coverage              84.18%   84.20%   +0.01%     
=====================================================
  Files                   1439     1439              
  Lines                 124672   124887     +215     
  Branches               15548    15588      +40     
=====================================================
+ Hits                  104956   105158     +202     
+ Misses                 12582    12577       -5     
- Partials                7134     7152      +18     
Flag Coverage Δ
ci 84.20% <90.24%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...w.Integration.AI/AgentWorkflowToolSourceAdapter.cs 82.38% <90.24%> (+1.17%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Studio workflow tools stay reachable for the built-in Studio workflow without returning to public/default toolsets or global agent sources.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant