Repository navigation
feat(observability): observe HTTP response delivery - #13
Draft
afourniernv wants to merge 1 commit into
Draft
afourniernv wants to merge 1 commit into
afourniernv wants to merge 1 commit into
Conversation
2 of 5 tasks
afourniernv
force-pushed
the
feat/5398-terminal-delivery/afourniernv
branch
from
November 17, 2026 17:27
967d7d0 to
ca088dc
Compare
afourniernv
force-pushed
the
feat/5397-mcp-correlation/afourniernv
branch
from
November 17, 2026 17:27
d0f6e48 to
745d8e1
Compare
Signed-off-by: Alex Fournier <afournier@nvidia.com>
afourniernv
force-pushed
the
feat/5397-mcp-correlation/afourniernv
branch
from
November 18, 2026 00:48
745d8e1 to
185d4d6
Compare
afourniernv
force-pushed
the
feat/5398-terminal-delivery/afourniernv
branch
from
November 18, 2026 00:48
ca088dc to
e888964
Compare
afourniernv
changed the base branch from
feat/5397-mcp-correlation/afourniernv
to
main
November 18, 2026 00:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add passive delivery observations to the existing HTTP response span. This is independently based on main and #5214; it remains a separate, last-review item rather than depending on the other correlation follow-ups.
Related Issue
Closes NVIDIA#5398. Tracking: NVIDIA#5210.
Changes
returned, notcompleted. Accepted writes do not prove peer receipt or application execution.Integration note: this and credentials #10 add different stage fields in the same function. Preserve both field sets when combining them; neither depends on the other.
Release Notes
The response span distinguishes initial status from delivery observations. These fields supplement, rather than replace, the request's policy outcome.
Testing
Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
Independent network Nextest suite: 1,728 passed; seven skipped. All five focused delivery tests passed.
The new real whole-body middleware regression checks transformed response bytes and headers while requiring
delivery_outcome=returned, notcompleted.Existing delivery tests cover partial writes, framing, downstream failures, cancellation and close-delimited idle timeout versus EOF.
Full independent and combined pre-commit checks, including strict Clippy, passed. Combined Nextest: 1,892 passed; seven skipped. Network Cargo tests with telemetry disabled: 1,731 passed; two ignored.
Fresh Hermes/Relay execution verified premature framed-body EOF: client
IncompleteRead, preserved HTTP 200 statuses,delivery_outcome=failed, positive accepted bytes and the response failure reason. Real response-middleware replacement remainsreturned, notcompleted. These live cases use the combined follow-up build; the independent suite above qualifies this branch alone.The broad workspace task is not green: an unchanged packaging assertion reproduces on pinned main, and a separate VM image-preparation test failed once then passed in isolation. Those files are outside this change.
Checklist