Skip to content

feat(observability): trace remote HTTP middleware RPCs - #9

Draft
afourniernv wants to merge 1 commit into
mainfrom
feat/5394-middleware-correlation/afourniernv
Draft

afourniernv wants to merge 1 commit into
mainfrom
feat/5394-middleware-correlation/afourniernv

Conversation

@afourniernv

@afourniernv afourniernv commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Trace remote HTTP middleware RPCs beneath the supervisor's existing middleware stages. This is independently based on main, which already contains HTTP correlation core #5214.

Related Issue

Closes NVIDIA#5394. Tracking: NVIDIA#5210.

Changes

  • Reuse the shared trace-context interceptor, status guard and traced gRPC stream.
  • Propagate the supervisor's active context and retain RPC spans until the response stream ends or is dropped.
  • Distinguish successful policy refusals from transport failures without exporting payloads, bearer tokens or error messages.
  • Leave existing phase spans, per-control OCSF records, middleware results, WebSocket sessions and configuration RPCs unchanged.

No new external Rust API, protobuf field or configuration. This does not depend on the other correlation follow-ups.

Release Notes

Remote HTTP middleware calls can be followed from the supervisor's middleware stage into a service that exports compatible traces.

Testing

  • Checks appropriate to the affected code and behavior pass

  • Unit tests added/updated (if applicable)

  • E2E tests added/updated (if applicable)

  • Independent middleware Nextest suite: 157 passed.

  • Tests cover context replacement, rotating bearer preservation, stream lifetime, refusal versus transport failure, and excluding sensitive fields.

  • Full independent and combined pre-commit checks, including strict Clippy, passed. Combined Nextest: 1,892 passed; seven skipped. Network Cargo tests with telemetry disabled: 1,731 passed; two ignored.

  • Fresh Hermes/Relay execution verified request/response redaction, guard refusal and recovery, with real RPC children. A successful refusal RPC remains distinct from HTTP admission. These live cases use the combined follow-up build; the independent suite above qualifies this branch alone.

  • The broad workspace task is not green: an unchanged packaging assertion reproduces on pinned main, and a separate VM image-preparation test failed once then passed in isolation. Those files are outside this change.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable): published trace guidance updated; subsystem boundaries unchanged.

@afourniernv
afourniernv force-pushed the codex/relay-state-01-correlation-primitives branch 2 times, most recently from 11030e5 to 0f92636 Compare November 16, 2026 01:13
@afourniernv
afourniernv force-pushed the feat/5394-middleware-correlation/afourniernv branch from 9501490 to fbac941 Compare November 17, 2026 17:27
@afourniernv afourniernv changed the title feat(observability): correlate supervisor middleware decisions and changes feat(observability): trace remote HTTP middleware RPCs Nov 17, 2026
@afourniernv
afourniernv changed the base branch from codex/relay-state-01-correlation-primitives to main November 17, 2026 17:28
Signed-off-by: Alex Fournier <afournier@nvidia.com>
@afourniernv
afourniernv force-pushed the feat/5394-middleware-correlation/afourniernv branch from fbac941 to b23f552 Compare November 18, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(observability): trace remote HTTP middleware RPCs

1 participant