Repository navigation
docs: fix nonexistent schema-0NN-rollout.md reference in backup runbook - #266
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
|
PetrefiedThunder
left a comment
There was a problem hiding this comment.
REVIEW: PASS claude 7497f7b
Scope: 1 commit, 1 file, +1/-1, gateway/docs/backup-restore-runbook.md:474. It changes the backticked schema-0NN-rollout.md to the plain-prose "schema-NNN rollout doc". The meaning is unchanged and nothing else in the diff changes (merge-base 2674423 = main tip, #265).
Reference check: the head has no other 0NN/NNN token. The new text has no backticks and no .md name, so neither the doc-reference gate nor the markdown-existence check sees it as a link.
Local, scratch worktree at this head (load ~18–24):
tests/test_docs_reference_integrity.py: 9 passed.- The same file with the base runbook swapped in:
test_docs_markdown_references_existFAILS onbackup-restore-runbook.md: schema-0NN-rollout.md. This matches main CI run 40458242079 (Python 3.12/3.13), so the fix is the cause. scripts/check_doc_references.py: 850 refs OK.tests/test_docs_links.pyandtests/test_check_doc_references.py: 24 passed.
CI at this head: CI result, lint, gitleaks, CodeQL (3 analyzers), licenses, CodeRabbit, Cursor Bugbot and Vercel all pass. The matrix and Postgres jobs are skipped because this is a docs-only path filter, so the docs test ran here locally only.
Fixes main red from #265:
gateway/docs/backup-restore-runbook.mdreferencedschema-0NN-rollout.mdin backticks, which test_docs_markdown_references_exist treats as a file reference. Changed to plain text "schema-NNN rollout doc". One line, docs only.Local: tests/test_docs_reference_integrity.py 1 failed / 8 passed on main 2674423, 9 passed after fix.
Reviewer: Claude.
Note
Low Risk
Single-line documentation wording change with no effect on application code or deployment procedures.
Overview
Fixes a docs reference integrity failure in the backup/restore runbook verification section.
Item 6 previously used backticks around
schema-0NN-rollout.md, whichtest_docs_markdown_references_existtreats as a concrete markdown path. That placeholder file does not exist in the tree. The wording is now plain text—schema-NNN rollout doc—with the same meaning (per-revision checks like legacy permits for 040, demo kill switch for 043, etc.).No runtime or operational behavior changes; this unblocks the docs markdown reference test from #265.
Reviewed by Cursor Bugbot for commit 7497f7b. Bugbot is set up for automated code reviews on this repo. Configure here.