Skip to content

test(hydrator): refresh the device.container capture from OpenShell v0.1.8 - #31

Merged
csnitker-godaddy merged 2 commits into
agentnameservice:mainfrom
chou-godaddy:pr/hydrator-fixture-v0.1.8
Nov 17, 2026
Merged

csnitker-godaddy merged 2 commits into
agentnameservice:mainfrom
chou-godaddy:pr/hydrator-fixture-v0.1.8

Conversation

@chou-godaddy

Copy link
Copy Markdown
Contributor

Related issue

Fixes #25

Summary

TestRunUpstreamDeviceContainerCapture runs the hydrator over real supervisor records that carry the sandbox only in device.container. #24 captured them from an OpenShell dev build of main at 1cdfe70, because no release included NVIDIA/OpenShell#5048 yet. OpenShell v0.1.8, released 2026-11-10, is the first release that does.

This PR replaces the capture with 14 unedited records from the v0.1.8 supervisor and updates the test's comment and sandbox constants. No hydrator code changes.

Testing

  • Captured with this repo's smoke harness (examples/openshell-smoke/smoke.sh --keep-running), with openshell-release.env pointed at v0.1.8 on my machine: tag commit f3d9765, the 0.1.8 supervisor and sandbox image digests, and the CLI and gateway checksums from the release. After turning on ocsf_json_enabled, I sent one allowed request to the callee and one request to https://example.com that the policy denies, the same flows as the earlier capture. Moving the pin is not part of this PR.
  • The new records have the same fields as the 1cdfe70 capture. Only per-run values differ: sandbox name and UID, times, IDs, and the host's private address. Every record carries the sandbox in device.container, and none has a top-level container.
  • The test passes with its expected counts unchanged: 14 records attributed, 2 denied, 3 observations. With Event.Sandbox() ignoring device.container, both subtests fail with all 14 records unmapped.
  • go test -race ./..., go vet ./..., gofmt and golangci-lint v2.10.1: all pass, 0 issues. Library coverage 98.5%.

AI assistance

Assisted-by: Cursor (Claude Opus 5.5)

Checklist

  • The PR title follows Conventional Commits — release notes are generated from it
  • Tests cover the change
  • I linked the relevant issue or proposal, or explained why no separate issue is needed
  • Every commit is signed off (git commit -s) certifying the DCO

…0.1.8

The device.container test data came from an OpenShell dev build because
no release included NVIDIA/OpenShell#5048 yet. v0.1.8 is the first
release that does, so replace the capture with unedited records from
its supervisor.

Fixes agentnameservice#25

Signed-off-by: chou-godaddy <chou@godaddy.com>
@csnitker-godaddy
csnitker-godaddy requested review from a team as code owners November 17, 2026 20:47
@csnitker-godaddy
csnitker-godaddy merged commit 8b21b57 into agentnameservice:main Nov 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hydrator: refresh the device.container test capture from an OpenShell release

2 participants