Repository navigation
test(hydrator): refresh the device.container capture from OpenShell v0.1.8 - #31
Merged
csnitker-godaddy merged 2 commits intoNov 17, 2026
Conversation
…0.1.8 The device.container test data came from an OpenShell dev build because no release included NVIDIA/OpenShell#5048 yet. v0.1.8 is the first release that does, so replace the capture with unedited records from its supervisor. Fixes agentnameservice#25 Signed-off-by: chou-godaddy <chou@godaddy.com>
csnitker-godaddy
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #25
Summary
TestRunUpstreamDeviceContainerCaptureruns the hydrator over real supervisor records that carry the sandbox only indevice.container. #24 captured them from an OpenShell dev build ofmainat1cdfe70, because no release included NVIDIA/OpenShell#5048 yet. OpenShell v0.1.8, released 2026-11-10, is the first release that does.This PR replaces the capture with 14 unedited records from the v0.1.8 supervisor and updates the test's comment and sandbox constants. No hydrator code changes.
Testing
examples/openshell-smoke/smoke.sh --keep-running), withopenshell-release.envpointed at v0.1.8 on my machine: tag commitf3d9765, the0.1.8supervisor and sandbox image digests, and the CLI and gateway checksums from the release. After turning onocsf_json_enabled, I sent one allowed request to the callee and one request tohttps://example.comthat the policy denies, the same flows as the earlier capture. Moving the pin is not part of this PR.1cdfe70capture. Only per-run values differ: sandbox name and UID, times, IDs, and the host's private address. Every record carries the sandbox indevice.container, and none has a top-levelcontainer.Event.Sandbox()ignoringdevice.container, both subtests fail with all 14 records unmapped.go test -race ./...,go vet ./...,gofmtandgolangci-lintv2.10.1: all pass, 0 issues. Library coverage 98.5%.AI assistance
Assisted-by: Cursor (Claude Opus 5.5)
Checklist
git commit -s) certifying the DCO