Skip to content

fix(dashscope): broaden kimi-k multimodal detection to cover all vari… - #2928

Open
charliejinc wants to merge 1 commit into
agentscope-ai:mainfrom
charliejinc:fix/kimi-multimodal-detection
Open

fix(dashscope): broaden kimi-k multimodal detection to cover all vari…#2928
charliejinc wants to merge 1 commit into
agentscope-ai:mainfrom
charliejinc:fix/kimi-multimodal-detection

Conversation

@charliejinc

Copy link
Copy Markdown

…ants

Replace specific kimi-k2.5/kimi-k2.6 checks with a single kimi-k contains match so that k2.7-code, k3 and future variants are detected. Add kimi-k2-thinking and moonshot-kimi-k2-instruct to the text-only exclusion list.

AgentScope-Java Version

[The version of AgentScope-Java you are working on, e.g. 1.0.12, check your pom.xml dependency version or run mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]

Description

[Please describe the background, purpose, changes made, and how to test this PR]

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

…ants

Replace specific kimi-k2.5/kimi-k2.6 checks with a single kimi-k
contains match so that k2.7-code, k3 and future variants are detected.
Add kimi-k2-thinking and moonshot-kimi-k2-instruct to the text-only
exclusion list.
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...xtensions/model/dashscope/DashScopeHttpClient.java 75.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@jujn

jujn commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

请签署 CLA

@oss-maintainer

Copy link
Copy Markdown
Collaborator

CLA Not Signed

The Contributor License Agreement (CLA) check is currently pending on this PR (license/cla: Contributor License Agreement is not signed yet.). This PR cannot be merged until the CLA is signed.

@charliejinc please sign the CLA via the CLA assistant badge in the comment above, or visit https://cla-assistant.io/agentscope-ai/agentscope-java. Once signed, the license/cla status will turn green.


Automated check by github-manager-bot

@oss-maintainer oss-maintainer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR broadens DashScope isMultimodalModel detection from specific kimi-k2.5/kimi-k2.6 checks to any model name containing kimi-k, and adds kimi-k2-thinking and moonshot-kimi-k2-instruct to the text-only exclusion list. The logic is correct: exclusions are evaluated before the broad match, case handling is consistent with the rest of the method, and the new test covers the expected multimodal and text-only variants including case-insensitive and path-like model names. No issues found.

Findings

The change looks clean.

Note: this PR cannot be approved until the CLA is signed (see CLA reminder).


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants