fix(dashscope): broaden kimi-k multimodal detection to cover all vari… - #2928
fix(dashscope): broaden kimi-k multimodal detection to cover all vari…#2928charliejinc wants to merge 1 commit into
Conversation
…ants Replace specific kimi-k2.5/kimi-k2.6 checks with a single kimi-k contains match so that k2.7-code, k3 and future variants are detected. Add kimi-k2-thinking and moonshot-kimi-k2-instruct to the text-only exclusion list.
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
请签署 CLA |
|
CLA Not Signed The Contributor License Agreement (CLA) check is currently pending on this PR ( @charliejinc please sign the CLA via the CLA assistant badge in the comment above, or visit https://cla-assistant.io/agentscope-ai/agentscope-java. Once signed, the Automated check by github-manager-bot |
oss-maintainer
left a comment
There was a problem hiding this comment.
Summary
This PR broadens DashScope isMultimodalModel detection from specific kimi-k2.5/kimi-k2.6 checks to any model name containing kimi-k, and adds kimi-k2-thinking and moonshot-kimi-k2-instruct to the text-only exclusion list. The logic is correct: exclusions are evaluated before the broad match, case handling is consistent with the rest of the method, and the new test covers the expected multimodal and text-only variants including case-insensitive and path-like model names. No issues found.
Findings
The change looks clean.
Note: this PR cannot be approved until the CLA is signed (see CLA reminder).
Automated review by github-manager-bot
…ants
Replace specific kimi-k2.5/kimi-k2.6 checks with a single kimi-k contains match so that k2.7-code, k3 and future variants are detected. Add kimi-k2-thinking and moonshot-kimi-k2-instruct to the text-only exclusion list.
AgentScope-Java Version
[The version of AgentScope-Java you are working on, e.g. 1.0.12, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)