Repository navigation
Maintenance sweep: Node 26 support, release 2.9.1 - #104
Merged
Merged
Conversation
Widen engines.node to >=22 <27 and add a CI job that runs the suite on Node 22, 24 and 26, so the declared range matches what CI tests. Bump lefthook to 2.2.1 and bun to 1.4.3, and drop the smol-toml and source-map-js overrides, which a fresh resolution no longer needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engines.nodewidens from>=22 <25to>=22 <27, so installs on Node 26 (current since May, LTS this month) stop warning.node-compatCI job runs the suite on Node 22, 24 and 26. The declared range was meant to match the tested majors, but CI only ran the runner image's default Node; now it tests each one.packageManagerbun 1.4.3.smol-tomlandsource-map-jsoverrides: removing them against the existing lock changes nothing, and a fresh resolution lands on smol-toml 1.9.1 and source-map-js 1.2.2, both at or above the old floors. Theesbuildoverride stays (0.27.7 without it).Worked with Varun.
Not taken: eslint 10 and TypeScript 7 stay held (eslint-plugin-import's eslint peer still stops at 9; typescript-eslint 8.71.1 peers
typescript <6.1.0).Type of change
Public API
No change. Only the
enginesmetadata widens.Test plan
Locally: lint, typecheck, knip, test with coverage (154 passed, 2 skipped) and build all exit 0. The suite also passes under Node 22.23.2, 24.21.0 and 26.11.1 via nvm. OSV scan clean.
Checklist