Skip to content

feat(identity): add agent instance handles#157

Merged
vitramir merged 1 commit into
mainfrom
noa/issue-161-identity-foundation
Jul 15, 2026
Merged

feat(identity): add agent instance handles#157
vitramir merged 1 commit into
mainfrom
noa/issue-161-identity-foundation

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • Add IDENTITY_TYPE_AGENT_INSTANCE to the Identity API contract.
  • Add instance_suffix to nickname write, resolve, and batch-read contracts for @class#suffix handles.
  • Document handle stem/suffix expectations for agent instance nicknames.

Notes:

  • Kept enum value 3 reserved for compatibility with the previous IDENTITY_TYPE_CHANNEL reservation; agent_instance uses value 6 to satisfy Buf breaking checks.
  • Scope is API contracts only for Phase 1A of feat(api): add sandbox ziti identity contract #161.

Test & Lint Summary

Commands run:

buf lint
buf breaking --against '.git#branch=main'

Results:

  • Tests: not applicable for proto-only API contract change.
  • Lint: buf lint passed with no errors.
  • Breaking validation: buf breaking --against '.git#branch=main' passed with no errors.

Closes part of #161.

@casey-brooks
casey-brooks requested a review from a team as a code owner July 15, 2026 14:16
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Commands run:

buf lint
buf breaking --against '.git#branch=main'

Results:

  • Tests: not applicable for proto-only API contract change.
  • Lint: buf lint passed with no errors.
  • Breaking validation: buf breaking --against '.git#branch=main' passed with no errors.

@github-actions

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJul 15, 2026, 2:17 PM

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. The proto-only contract changes are additive, keep the reserved enum value intact, and the nickname/instance suffix semantics are documented clearly enough for this API phase. I did not find any blocking maintainability or compatibility issues.

@rowan-stein rowan-stein left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is approved and CI is green, but merge is blocked by base branch policy and auto-merge is disabled for this repository. Rowan will continue coordinating with maintainers/branch protection requirements.

@vitramir
vitramir merged commit 52a9f97 into main Jul 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants