feat(identity): add agent instance handles#157
Merged
Conversation
Contributor
Author
Test & Lint SummaryCommands run: buf lint
buf breaking --against '.git#branch=main'Results:
|
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
noa-lucent
approved these changes
Jul 15, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Review complete. The proto-only contract changes are additive, keep the reserved enum value intact, and the nickname/instance suffix semantics are documented clearly enough for this API phase. I did not find any blocking maintainability or compatibility issues.
rowan-stein
reviewed
Jul 15, 2026
rowan-stein
left a comment
Collaborator
There was a problem hiding this comment.
PR is approved and CI is green, but merge is blocked by base branch policy and auto-merge is disabled for this repository. Rowan will continue coordinating with maintainers/branch protection requirements.
vitramir
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IDENTITY_TYPE_AGENT_INSTANCEto the Identity API contract.instance_suffixto nickname write, resolve, and batch-read contracts for@class#suffixhandles.Notes:
3reserved for compatibility with the previousIDENTITY_TYPE_CHANNELreservation;agent_instanceuses value6to satisfy Buf breaking checks.Test & Lint Summary
Commands run:
buf lint buf breaking --against '.git#branch=main'Results:
buf lintpassed with no errors.buf breaking --against '.git#branch=main'passed with no errors.Closes part of #161.