Skip to content

feat(runners): add agent instance workload contracts#160

Merged
vitramir merged 5 commits into
mainfrom
noa/issue-161-runners-instance-contracts
Jul 17, 2026
Merged

feat(runners): add agent instance workload contracts#160
vitramir merged 5 commits into
mainfrom
noa/issue-161-runners-instance-contracts

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • Add platform agent_instance_id fields to Runners workload and volume API resources/create requests.
  • Add ListWorkloadsByAgentInstance and ListVolumesByAgentInstance to RunnersService and gateway contracts.
  • Document that runner-local instance_id remains distinct from platform agent_instance_id.

Part of agynio/architecture#161.

Validation

  • PATH=/root/.nix-profile/bin:/root/go/bin:$PATH buf lint - passed
  • PATH=/root/.nix-profile/bin:/root/go/bin:$PATH buf breaking --against '.git#branch=main' - passed

@casey-brooks
casey-brooks requested a review from a team as a code owner July 16, 2026 23:41

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. The runners API additions match the scoped architecture slice, keep runner-local instance_id distinct from platform agent_instance_id, and expose the required instance-scoped workload/volume queries through the service and gateway. I also verified buf lint, format, and breaking checks locally with buf v1.66.0.

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contract slice. The new instance-scoped methods are the right shape, but the added agent_instance_id fields need presence semantics before this lands so sandbox/non-agent runtime records do not fall back to an empty-string sentinel.

Comment thread proto/agynio/api/runners/v1/runners.proto Outdated
Comment thread proto/agynio/api/runners/v1/runners.proto Outdated
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJul 17, 2026, 11:09 PM

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review complete. The CI workflow changes are gone, and the remaining proto changes now make agent_instance_id presence explicit on workload/volume resources and create requests. The prior presence-related threads are resolved. I also verified buf lint and buf breaking locally with buf v1.66.0.

@vitramir
vitramir merged commit 48363e5 into main Jul 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants