fix(sqlite): require WAL reset fix - #111
Conversation
SQLite 3.51.3 closes the documented WAL reset race across separate writer and checkpoint connections. Keep Rust, TypeScript, CI, and the shared runtime fixture on one floor.
|
Warning Review limit reachedNext included review available in 28 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 108 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
Comment |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (9 files)
Previous Review Summary (commit a2c846f)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit a2c846f)Status: No Issues Found | Recommendation: Merge Files Reviewed (8 files)
Reviewed by gemini-3.7-flash · Input: 176.5K · Output: 9.5K · Cached: 257.3K |
Resolve the ci.yml conflict by keeping both steps: main's taiki-e/install-action@nextest setup, which the mc-module nextest step depends on, ahead of this branch's mc-store commons test.
Keep the SQLite version floor, its rejection reason, and the tests that assert both derived from one constant, so a future floor change cannot drift. Prove the floor comparison is numeric, not lexical, and check the bundled engine against the floor rather than one pinned release. CI resolves commons at the revision carrying the matching rusqlite line.
Summary
Dependency
Requires ahrav/commons#4. CI pins that commit until it merges.
Stack
Part 1 of 8. Base layer for #112.