Skip to content

fix(sqlite): require WAL reset fix - #111

Merged
ahrav merged 3 commits into
mainfrom
stack/kernel-01-sqlite
Aug 30, 2026
Merged

fix(sqlite): require WAL reset fix#111
ahrav merged 3 commits into
mainfrom
stack/kernel-01-sqlite

Conversation

@ahrav

@ahrav ahrav commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • align Rust, TypeScript, fixtures, and CI on SQLite 3.51.3
  • require the upstream WAL reset fix before opening direct-format databases
  • keep runtime source-ID checks pinned to the supported engine

Dependency

Requires ahrav/commons#4. CI pins that commit until it merges.

Stack

Part 1 of 8. Base layer for #112.

SQLite 3.51.3 closes the documented WAL reset race across separate writer and checkpoint connections. Keep Rust, TypeScript, CI, and the shared runtime fixture on one floor.
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 28 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 108 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5e29e724-6556-428b-be35-36549d7fce02

📥 Commits

Reviewing files that changed from the base of the PR and between 4496cd6 and eacfad6.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • .github/workflows/ci.yml
  • Cargo.toml
  • crates/mc-store/src/sqlite_runtime.rs
  • crates/mc-store/tests/sqlite_runtime.rs
  • packages/plugin/src/features/magic-context/fixtures/direct-format-vocabulary-v1.json
  • packages/plugin/src/features/magic-context/storage-db.test.ts
  • packages/plugin/src/features/magic-context/storage-format-epoch.test.ts
  • packages/plugin/src/shared/sqlite.ts

Comment @coderabbitai help to get the list of available commands.

@ahrav
ahrav marked this pull request as ready for review August 30, 2026 16:52
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@kilo-code-bot

kilo-code-bot Bot commented Aug 30, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (9 files)
  • .github/workflows/ci.yml
  • Cargo.lock
  • Cargo.toml
  • crates/mc-store/src/sqlite_runtime.rs
  • crates/mc-store/tests/sqlite_runtime.rs
  • packages/plugin/src/features/magic-context/fixtures/direct-format-vocabulary-v1.json
  • packages/plugin/src/features/magic-context/storage-db.test.ts
  • packages/plugin/src/features/magic-context/storage-format-epoch.test.ts
  • packages/plugin/src/shared/sqlite.ts
Previous Review Summary (commit a2c846f)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit a2c846f)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (8 files)
  • .github/workflows/ci.yml
  • Cargo.lock
  • Cargo.toml
  • crates/mc-store/src/sqlite_runtime.rs
  • crates/mc-store/tests/sqlite_runtime.rs
  • packages/plugin/src/features/magic-context/fixtures/direct-format-vocabulary-v1.json
  • packages/plugin/src/features/magic-context/storage-db.test.ts
  • packages/plugin/src/shared/sqlite.ts

Reviewed by gemini-3.7-flash · Input: 176.5K · Output: 9.5K · Cached: 257.3K

ahrav added 2 commits August 30, 2026 18:21
Resolve the ci.yml conflict by keeping both steps: main's
taiki-e/install-action@nextest setup, which the mc-module nextest
step depends on, ahead of this branch's mc-store commons test.
Keep the SQLite version floor, its rejection reason, and the tests that assert both derived from one constant, so a future floor change cannot drift. Prove the floor comparison is numeric, not lexical, and check the bundled engine against the floor rather than one pinned release. CI resolves commons at the revision carrying the matching rusqlite line.
@ahrav
ahrav merged commit fa3652e into main Aug 30, 2026
15 of 18 checks passed
@ahrav
ahrav deleted the stack/kernel-01-sqlite branch August 30, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant