Skip to content

chore: the console team owns the repository, infra owns CI - #140

Open
Gkrumbach07 wants to merge 2 commits into
ai-openshell:mainfrom
Gkrumbach07:chore/codeowners-infra
Open

Gkrumbach07 wants to merge 2 commits into
ai-openshell:mainfrom
Gkrumbach07:chore/codeowners-infra

Conversation

@Gkrumbach07

Copy link
Copy Markdown
Contributor

Replaces #135, rebased onto main and opened from my fork.

Why

main-integrity needs one code owner's approval to merge, and CODEOWNERS names only me, so none of my pull requests can merge (#134, #138 and #139 are all blocked). Separately, Simon asked that changes to CI get a security review from infra.

What changes

The console team owns the repository by default. * @ai-openshell/console, the org team of the console's maintainers (Gkrumbach07, danreed-rh). It has two members, so each can approve the other's PRs. Being a team means a maintainer joins or leaves in the org's team settings, not in this file. This is how sdk-go does it with @ai-openshell/sdk.

Infra owns CI and release automation. @ai-openshell/infra owns:

These lines come after the default, and the last matching rule wins, so for these paths a change needs an approval from someone in infra.

The root CODEOWNERS is removed. .github/CODEOWNERS takes precedence, so the root file was ignored. The separate ADR and auth rules named the same owner as the default, so they're gone too.

Both teams have write on the repo (checked through the team API), so GitHub counts them as owners.

Merging this needs an admin

Under the current rules, the owner of CODEOWNERS is only me, and I can't approve my own PR. An org admin has to approve or bypass once. After that, Dan and I can approve each other, and infra approves CI changes.

🤖 Generated with Claude Code

Gkrumbach07 and others added 2 commits November 17, 2026 10:27
The workflows, the release scripts and the upstream bump bot hold the
tokens that publish packages and push branches. Simon asked for the
organization's infra team to review changes to them; this makes
@ai-openshell/infra the code owner of .github/, scripts/release/,
scripts/retag-image.sh, scripts/branch-tip.sh and deploy/ci/upstream/.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>
CODEOWNERS named only Gkrumbach07, and main-integrity needs one code owner's
approval, so no pull request of his could merge. The default owner is now the
ai-openshell/console team (Gkrumbach07 and danreed-rh), as sdk-go uses
ai-openshell/sdk, so each maintainer can approve the other's work. The ADR and
auth rules named the same owner as the default and are dropped.

The root CODEOWNERS goes: .github/CODEOWNERS takes precedence, so it was dead.
scripts/quay-login.sh (ai-openshell#134) joins the files infra reviews.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants