Repository navigation
chore: follow the Go SDK at ai-openshell/sdk-go - #141
Open
Gkrumbach07 wants to merge 1 commit into
Open
Gkrumbach07 wants to merge 1 commit into
Gkrumbach07 wants to merge 1 commit into
Conversation
The Go SDK left NVIDIA/OpenShell: it is now the module github.com/ai-openshell/sdk-go, whose tag vX.Y.Z is the SDK for core vX.Y.Z, cut after core releases. sdk/go/v0.1.8 is the last tag at the old path, so the next core release would have no SDK where Follow upstream looks. Follow upstream now reads the target's SDK tag from sdk-go. While sdk-go has not tagged the release, the plan has no SDK, the bump output is false and the run summary says the bump waits; check A still runs. Nothing else is pinned in its place. The pin move runs `go get github.com/ai-openshell/sdk-go@vX.Y.Z` and checks with `go list -m -json` that the tag is the commit the plan read. A tree still on github.com/NVIDIA/OpenShell/sdk/go stays valid (the pins check in CI and gateway-range.mjs read either path), and the pin move that takes it to sdk-go rewrites backend/**/*.go to the new import path in the same commit; bump.py lets it commit exactly those files. So the import rewrite lands on the bump branch, not by hand (hard fact 17). Rules, ADR 0003, ADR 0005 (amendment A7), architecture.md and the upstream README say where the SDK comes from now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go SDK moved out of NVIDIA/OpenShell. It is now the module
github.com/ai-openshell/sdk-go. Its tagvX.Y.Zis the SDK for corevX.Y.Z, and sdk-go cuts that tag after core releases.sdk/go/v0.1.8is the last tag at the old path, so on the next core release Follow upstream would find no SDK.Follow upstream
planreads the target's SDK tag from sdk-go withgit ls-remote. When sdk-go has not tagged the release yet:sdkis null andsdk_waiting_forsays why;bumpoutput isfalse, andpublish.blockedrefuses too;go get github.com/ai-openshell/sdk-go@vX.Y.Z, then checks withgo list -m -jsonthat the tag is the commitplanread.github.com/NVIDIA/OpenShell/sdk/gois valid. The pin move that takes it to sdk-go rewritesbackend/**/*.goto the new import path beforego mod tidy.bump.pylets it commit exactly those files along with the pins. The rewrite therefore lands on the bump branch the workflow makes. The pins are never moved by hand (hard fact 17), and this PR does not move them:mainstays on 0.1.6 and the old path.Pins check:
follow.py validate-pins --go-modandscripts/gateway-range.mjs --checkread the SDK from either module path. The rule thatsdkmust equal go.mod holds before and after the move.Docs: these now say where the SDK comes from and that the bump waits for its tag:
.claude/rules/openshell-api.md(hard facts 17 and 20) and.claude/rules/bff-go.mddocs/architecture.mdanddeploy/ci/upstream/README.mdTested
python3 -m unittest discover -s tests -t .indeploy/ci/upstream: 296 pass. New tests cover:node --test "scripts/**/*.test.mjs": 89 pass.gotools rewrote 74 Go files and left no old-path reference.go build ./...,go vet ./...andgo test ./...pass on the result. Nothing from that run is committed.The bump still can't open its PR until the
bump-botApp secrets exist. That is separate org-admin work.🤖 Generated with Claude Code