Repository navigation
Conversation
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The org is moving images and charts to Quay, and infra wants no stored registry secret. ai-openshell/console#134 does this with
scripts/quay-login.sh. This turns it into a reusable action so every repo can use it.What
quay-loginasks GitHub for the job's OIDC token and trades it athttps://quay.io/oauth2/federation/robot/tokenfor a robot token that lasts one hour. It then logs in the clients the caller asks for:Compared with the bash script:
node24action with no dependencies, using built-infetch. No curl or jq.id-token: writefail before any network call, with a clear::error::.audienceis URL-encoded rather than appended as raw text.quay.iofor now.Also in this PR:
flake.nix: a devShell with Node 24 (nix develop).test.yml: alintjob that runsprettier --checkandnode --checkon the action.Not yet
TODOs mark the spots for a failed GitHub token request and a missing client binary.Testing
Locally:
prettier --check .andnode --checkpass. An unknown client and a missing OIDC token each fail with the expected error.The real exchange and logins haven't run yet. They need a job that a Quay robot trusts, such as console's
releaseenvironment usingai-openshell/workflows/quay-login@feat/quay-login-action.