feat(sdk): TSSDK-71 do not leak auth header in errors#149
Open
mk0x9 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 97.26% 97.28% +0.01%
==========================================
Files 14 14
Lines 1500 1511 +11
Branches 225 227 +2
==========================================
+ Hits 1459 1470 +11
Misses 41 41
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


handleRequestError in platform-sdk.ts attached the raw Axios error as originalError on thrown APIError/UnexpectedError instances. That error's config.headers carries the request's Authorization bearer token in plaintext, which leaks out through JSON.stringify/toJSON() or direct property access if a consumer logs or forwards the caught error to an error tracker.