Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions lib/plugins/Label_QQ.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,29 @@ describe('Label QQ', () => {
expect(decodeResult.formatted.items[2].value).toBe('00:58:00');
});

test('decodes Label QQ groundspeed placeholder after non-placeholder field (#507)', () => {
// Variant 1 layout but field 45..48 is '---' while 42..45 is '028'.
// Previously the guard tested remaining.text (the 42..45 field), so this
// message stored NaN groundspeed and rendered "NaN knots".
message.text = 'KLGBKLAX0004\r\n001FE07000444N3349.8W11810.1028---0009';
const decodeResult = plugin.decode(message);

expect(decodeResult.decoded).toBe(true);
expect(decodeResult.decoder.decodeLevel).toBe('partial');
expect(decodeResult.decoder.name).toBe('label-qq');
expect(decodeResult.raw.departure_icao).toBe('KLGB');
expect(decodeResult.raw.arrival_icao).toBe('KLAX');
expect(decodeResult.raw.position.latitude).toBe(33.83);
expect(decodeResult.raw.position.longitude).toBe(-118.16833333333334);
expect(decodeResult.raw.groundspeed).toBeUndefined();
expect(Number.isNaN(decodeResult.raw.groundspeed)).toBe(false);
Comment on lines +134 to +135
expect(decodeResult.remaining.text).toBe('028,---,0009');
expect(decodeResult.formatted.items.length).toBe(4);
expect(
decodeResult.formatted.items.some((item) => item.code === 'GSPD'),
).toBe(false);
});

// disabled because all messages should decode
test.skip('decodes Label QQ <invalid>', () => {
message.text = 'QQ Bogus message';
Expand Down
10 changes: 4 additions & 6 deletions lib/plugins/Label_QQ.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,11 @@ export class Label_QQ extends DecoderPlugin {
ResultFormatter.unknown(decodeResult, message.text.substring(42, 45));
ResultFormatter.position(decodeResult, pos);

if (decodeResult.remaining.text !== '---') {
ResultFormatter.groundspeed(
decodeResult,
Number(message.text.substring(45, 48)),
);
const gsField = message.text.substring(45, 48);
if (decodeResult.remaining.text !== '---' && gsField !== '---') {
ResultFormatter.groundspeed(decodeResult, Number(gsField));
} else {
ResultFormatter.unknown(decodeResult, message.text.substring(45, 48));
ResultFormatter.unknown(decodeResult, gsField);
}
ResultFormatter.unknown(decodeResult, message.text.substring(48));
} else {
Expand Down