Skip to content

Fix Rides preset page #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aligneddev merged 3 commits into from
Sep 29, 2026
Merged

Fix Rides preset page #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca79788
update aspire
Sep 29, 2026
d189977
Merge branch 'main' of github.com-personal:aligneddev/BikeCommuteTracker
Sep 29, 2026
bcf4753
fix presets link
Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/BikeTracking.Frontend/src/pages/RecordRidePage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,17 @@ describe('RecordRidePage', () => {
})
})

it('links Ride Preset setup to the settings page route', async () => {
render(
<BrowserRouter>
<RecordRidePage />
</BrowserRouter>
)

const link = await screen.findByRole('link', { name: /ride preset/i })
expect(link).toHaveAttribute('href', '/settings')
})

it('loads ride presets and does not render legacy quick options section', async () => {
mockGetRidePresets.mockResolvedValue({
presets: [
Expand Down
3 changes: 2 additions & 1 deletion src/BikeTracking.Frontend/src/pages/RecordRidePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { useEffect, useRef, useState } from 'react'
import { Link } from 'react-router-dom'
import type { CompassDirection, RidePreset, RecordRideRequest } from '../services/ridesService'
import {
getGasPrice,
Expand Down Expand Up @@ -340,7 +341,7 @@ export function RecordRidePage() {
return (
<div className="record-ride-page">
<h1>Record a Ride</h1>
<p>Do you repeat rides often? Setup a <a href="/rides/presets">Ride Preset</a>.</p>
<p>Do you repeat rides often? Setup a <Link to="/settings">Ride Preset</Link>.</p>
<p>
Need to add past rides in bulk? <a href="/rides/import">Import rides from CSV</a>.
</p>
Expand Down
Loading