Repository navigation
fix(productivity): use plain punctuation in write-naturally - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The write-naturally skill now uses straight apostrophes and spaced hyphens for dashes, including when proofreading a draft that already contains typographic punctuation. Its own prose and technical design reference follow the apostrophe rule.
Two fictional proofreading cases check that plain punctuation survives spelling fixes and that curly apostrophes and an em dash become keyboard punctuation. They use deterministic
not-regexandequalsassertions plus a skill-use check, with the default model graders disabled. The exact-message check also rejects missing hyphen spacing, unchanged typos, empty output and added commentary. The README documents the focused command.Validation:
bun run validatepassed.bun testpassed (58 tests).bun run eval:validatepassed.git diff --checkpassed.bun run eval:write-naturally --filter-metadata group=punctuation --max-concurrency 2 --no-progress-bar -o /tmp/write-naturally-punctuation-20261028-rerun.json: 2 passed, 0 failed, 0 errors, using Promptfoo 0.124.1 and gpt-6.1-sol with medium reasoning. Both traces recorded the repository-local skill read. No model grader was used.The focused live run covers the two new cases; the full 30-case model eval suite was not run. Local results:
/tmp/write-naturally-punctuation-20261028-rerun.json.