fix(release): give the platform packages a repository field - #20
Merged
Merged
Conversation
The v0.3.1 publish failed with: 422 Unprocessable Entity - Error verifying sigstore provenance bundle: package.json: "repository.url" is "", expected to match "https://github.com/alleneubank/linear-cli" from provenance OIDC auth itself worked — this is the next gate along. Trusted publishing turns on provenance automatically for public repos, and npm refuses an upload whose package.json does not name the repo the provenance attests to. Only the wrapper package had a repository field; the four platform packages had none. check-versions.sh now checks repository.url on every npm manifest. Everything else about v0.3.1 was green — tag, gate, GitHub release, all 8 assets — and it still could not publish, which is precisely the shape of failure a pre-publish gate exists to catch. Observed red against a deleted repository field before wiring it in. Bumps to 0.3.2; v0.3.1 reached GitHub but not npm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.3.1 publish failed:
OIDC auth worked — no 401, no 404. This is the next gate along.
Trusted publishing turns on sigstore provenance automatically for public repos, and npm refuses an upload whose
package.jsondoes not name the repo the provenance attests to. Only the wrapper had arepositoryfield; the four platform packages had none.The floor
scripts/check-versions.shnow checksrepository.urlon every npm manifest. Everything else about v0.3.1 was green — version gate, tag, GitHub release, all 8 assets — and it still could not publish. That is exactly the shape of failure a pre-publish gate exists to catch, so it earns a check rather than just a patch.Observed red before wiring it in:
Version
0.3.2. v0.3.1 reached GitHub (tag + release + assets) but never reached npm, which is still on 0.2.11.