Conversation
Add the dependencies and Make commands per the our other repos. Config needs to be in `mypy.ini` because we haven’t moved this repo to use `pyproject.toml` yet. Running `mypy` gives: > Found 6 errors in 2 files (checked 6 source files) These won’t block CI and can be fixed in followup PRs.
Not even sure how these iterators were working before
joybytes
approved these changes
Sep 21, 2026
risicle
approved these changes
Sep 21, 2026
Member
|
That iterator method is wild - just looks for anything that looks like a uuid. |
Member
|
This could probably do with a point release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the dependencies and Make commands per the our other repos.
Config needs to be in
mypy.inibecause we haven’t moved this repo to usepyproject.tomlyet.Running
mypygives:This PR fixes those errors, then turns on type checking in CI so more can’t get introduced.