Skip to content

fix: validate lakehouse upload files before streaming the payload#15

Merged
francoischalifour merged 4 commits into
mainfrom
fc/fix-upload-file-parsing
Jun 30, 2026
Merged

fix: validate lakehouse upload files before streaming the payload#15
francoischalifour merged 4 commits into
mainfrom
fc/fix-upload-file-parsing

Conversation

@francoischalifour

Copy link
Copy Markdown
Member

Summary

  • Check upload paths with statSync before building the lakehouse request so missing files and directories fail fast.
  • Pass the file size through the upload request instead of re-reading the file to size the progress reporter.
  • Add tests for the non-buffering upload path and for rejecting missing files and directories.

Testing

  • Added unit tests covering upload request construction and command-level file validation.

Risks

  • Behavior now depends on filesystem metadata instead of attempting to open the file contents, which should preserve the same user-facing error while avoiding unnecessary buffering.

@redox redox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@francoischalifour francoischalifour merged commit 0e49b6e into main Jun 30, 2026
4 checks passed
@francoischalifour francoischalifour deleted the fc/fix-upload-file-parsing branch June 30, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants