Improves IonContainer hashCode performance by ~30%.#1156
Merged
Conversation
NovemberZulu
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Results:
Container: IonList with 120 elements (monomorphic = all IonString; megamorphic = 6 types × 20)
JVM: Corretto 21, aarch64, -Xms3g -Xmx3g -XX:+UseParallelGC
poison=true pre-invokes hashCode() 40,000 times on the megamorphic container to simulate
real-world call-site pollution (JDK-8368292).
Credit: John Engebretson
Related: https://bugs.openjdk.org/browse/JDK-8368292
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.