Repository navigation
contrib: don't order the client HTTP socket after network-online.target - #87
Merged
Merged
Conversation
quarry-client-http.socket only listens on 127.0.0.1, so it never needs the network. But being a socket it is also Before=sockets.target, so its After=network-online.target puts the network on the boot path: on a machine without a network sockets.target and basic.target wait for systemd-networkd-wait-online to time out (120s), and everything after them waits too. Drop the network-online ordering from the socket. The service keeps its own, so the actual fetches still wait for the network. Signed-off-by: Michael Vogt <michael@amutable.com>
martinpitt
approved these changes
Oct 21, 2026
martinpitt
left a comment
martinpitt
left a comment
Member
There was a problem hiding this comment.
Ugh, yes. This was obviously wrong. Servers should never do that. Thanks!
Member
Author
|
@cyphar: I will merge this, I hope that is okay. If you have concern please speak up or just revert (if you see this too late) - and my apologies if I overstepped here. |
cyphar
approved these changes
Oct 22, 2026
Member
|
@mvo5 Beat you to it 😜 |
Member
|
And yeah, my bad -- I must've copy-pasted the section without thinking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quarry-client-http.socket only listens on 127.0.0.1, so it never needs the network. But being a socket it is also Before=sockets.target, so its After=network-online.target puts the network on the boot path: on a machine without a network sockets.target and basic.target wait for systemd-networkd-wait-online to time out (120s), and everything after them waits too.
Drop the network-online ordering from the socket. The service keeps its own, so the actual fetches still wait for the network.