Skip to content

docs(@angular/ssr): add SSRF security note to createNodeRequestHandle… #33370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karthikrajanv2026 wants to merge 1 commit into from
+8 −0
Closed

docs(@angular/ssr): add SSRF security note to createNodeRequestHandle… #33370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/angular/ssr/node/src/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ export type NodeRequestHandlerFunction = (
* });
* ```
*
* @remarks
* **Security note:** `createWebRequestFromNodeRequest()` builds the request URL directly from the
* `Host` and `X-Forwarded-*` headers and does not validate them. When integrating with a
* third-party framework as shown above, configure `allowedHosts` (and, if needed,
* `trustProxyHeaders`) via `AngularNodeAppEngine`, or otherwise validate these headers yourself,
* to prevent Server-Side Request Forgery (SSRF). For more information, see
* https://angular.dev/best-practices/security#preventing-server-side-request-forgery-ssrf.
*
* @example

@alan-agius4 alan-agius4 Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createNodeRequestHandler doesn't use createWebRequestFromNodeRequest.

* Usage in a Fastify application:
* ```ts
Expand Down
Loading